On Thu, 28 May 2026 at 19:45, Aditya GS <[email protected]> wrote: > > Backport upstream fix to improve stability of randtest.sh by > retrying when sigma is too small, avoiding intermittent failures. > > Upstream-Status: Backport [f2250f4bc864913437619af7a9834a1c24915acd]
Upstream-Status should only be in the patch file itself, not in the commit message for oe-core. Instead, provide a reference to the yocto bugzilla, so that the reviewers know which bug this is fixing. A http link or [YOCTO #nnnnnn] tag. > +Upstream-Status: Backport [f2250f4bc864913437619af7a9834a1c24915acd] It's better to link to the web interface: Upstream-Status: Backport [https://cgit.git.savannah.gnu.org/cgit/gawk.git/commit/?id=f2250f4bc864913437619af7a9834a1c24915acd] The reason is that sometimes a patch submission is labeled as Backport, but actually isn't (not here, of course). It's best to make that easy to verify, with a link like above. > @@ -19,6 +19,7 @@ SRC_URI = "${GNU_MIRROR}/gawk/gawk-${PV}.tar.gz \ > file://0001-m4-readline-add-missing-includes.patch \ > file://run-ptest \ > " > +SRC_URI += "file://randtest-fix.patch" You can simply change the main SRC_URI assignment and add the patch there, instead of making a new statement with +=. Other than this, looks good. Thanks for taking time to develop a proper fix, and getting upstream to accept it. It's much better to solve the issue properly, than simply skip the flaky tests. Alex
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#237721): https://lists.openembedded.org/g/openembedded-core/message/237721 Mute This Topic: https://lists.openembedded.org/mt/119535145/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
