Hi Richard, Thanks for the detailed feedback.
I've now reworked the patch against master, addressed the formatting issues, updated the Bugzilla reference to [YOCTO #16254], and resent the patch as v4. Please let me know if any further changes are needed. Thanks, Aditya On Mon, Jun 1, 2026, 12:07 PM Richard Purdie < [email protected]> wrote: > Hi, > > Thanks for the patch. I have a few pieces of feedback, just to help > streamline the patch merging process. > > Firstly, I think this might be against scarthgap as it has 5.3.0? > master/wrynose have 5.4.0. It isn't against master, you need to say > which branch it is against in the shortlog/subject, e.g. [scarthgap]. > We do also have a backport policy which means this needs to be applied > in master first, then backported to the LTS releases after that. > > On Mon, 2026-06-01 at 11:53 +0530, Aditya GS wrote: > > Backport upstream fix to improve stability of randtest.sh by > > retrying when sigma is too small, avoiding intermittent failures. > > > > https://bugzilla.yoctoproject.org/show_bug.cgi?id=16254 > > The convention for this is: > > [YOCTO #16254] > > > > > Signed-off-by: Aditya GS <[email protected]> > > --- > > .../gawk/files/randtest-fix.patch | 139 ++++++++++++++++++ > > meta/recipes-extended/gawk/gawk_5.3.0.bb | 1 + > > 2 files changed, 140 insertions(+) > > create mode 100644 meta/recipes-extended/gawk/files/randtest-fix.patch > > > > diff --git a/meta/recipes-extended/gawk/files/randtest-fix.patch > b/meta/recipes-extended/gawk/files/randtest-fix.patch > > new file mode 100644 > > index 0000000000..0b813e667e > > --- /dev/null > > +++ b/meta/recipes-extended/gawk/files/randtest-fix.patch > > @@ -0,0 +1,139 @@ > > +From f2250f4bc864913437619af7a9834a1c24915acd Mon Sep 17 00:00:00 2001 > > +From: "Arnold D. Robbins" <[email protected]> > > +Date: Thu, 28 May 2026 09:52:41 -0400 > > +Subject: [PATCH] Improve test/randtest.sh. > > + > > +Backport upstream fix to improve stability of randtest.sh by retrying > > +when sigma is too small, avoiding intermittent failures. > > + > > +Upstream-Status: Backport > > +[ > https://cgit.git.savannah.gnu.org/cgit/gawk.git/commit/?id=f2250f4bc864913437619af7a983 > > Missing closing brace and ideally shouldn't be line wrapped. > > > + function abs(abs_input) { return(sqrt(abs_input^2)) ; } > > + ' > > + > > +-- > > +2.34.1 > > + > > diff --git a/meta/recipes-extended/gawk/gawk_5.3.0.bb > b/meta/recipes-extended/gawk/gawk_5.3.0.bb > > index ac9d8500d6..06184a4b48 100644 > > --- a/meta/recipes-extended/gawk/gawk_5.3.0.bb > > +++ b/meta/recipes-extended/gawk/gawk_5.3.0.bb > > @@ -18,6 +18,7 @@ PACKAGECONFIG[mpfr] = "--with-mpfr,--without-mpfr, > mpfr" > > SRC_URI = "${GNU_MIRROR}/gawk/gawk-${PV}.tar.gz \ > > file://0001-m4-readline-add-missing-includes.patch \ > > file://run-ptest \ > > + file://randtest-fix.patch \ > > " > > Whitespace mismatch. > > Could you send a tweaked version against master please? I would like to > remove one of the intermittent ptest failures! > > Thanks, > > Richard >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#237825): https://lists.openembedded.org/g/openembedded-core/message/237825 Mute This Topic: https://lists.openembedded.org/mt/119586429/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
