Hi Mathieu, Thank you for running the selftests and catching this.
The root cause was that recipes using tag= in SRC_URI (like the gitunpackoffline selftest recipe) intentionally set SRCREV to empty, but my check incorrectly treated empty SRCREV as missing when tag= was present. The fix skips the SRCREV check when tag= is present in the URI, similar to the existing rev= handling. I verified locally: oe-selftest -r bbtests.BitbakeTests.test_git_unpack_nonetwork PASSED I have sent v5 with this fix. Best regards, Sai Sneha On Thu, 28 May 2026 at 6:38 PM, Mathieu Dubois-Briand < [email protected]> wrote: > On Wed May 27, 2026 at 1:17 PM CEST, Sai Sneha via lists.openembedded.org > wrote: > > This patch series adds a check for git:// (and other SCM) URIs in > > SRC_URI that are missing a corresponding SRCREV, addressing > > Bugzilla #16051 [1] and referencing Corentin Guillevic's RFC series [2]. > > > > Hi, > > Thanks for your patch. > > It looks like this is breaking the test_git_unpack_nonetwork selftest: > > 2026-05-28 09:51:08,030 - oe-selftest - INFO - > bbtests.BitbakeTests.test_git_unpack_nonetwork (subunit.RemotedTestCase) > 2026-05-28 09:51:08,030 - oe-selftest - INFO - ... FAIL > ... > ERROR: gitunpackoffline-0.0+git-r0 do_fetch: Bitbake Fetcher Error: > FetchError("Recipe uses a floating tag/branch '2.11' for repo ' > git.yoctoproject.org/matchbox-panel-2' without a fixed SRCREV yet doesn't > call bb.fetch2.get_srcrev() (use SRCPV in PV for OE).", None) > > https://autobuilder.yoctoproject.org/valkyrie/#/builders/23/builds/4009 > https://autobuilder.yoctoproject.org/valkyrie/#/builders/35/builds/3916 > > Can you have a look at the issue? > > Thanks, > Mathieu > > -- > Mathieu Dubois-Briand, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#238006): https://lists.openembedded.org/g/openembedded-core/message/238006 Mute This Topic: https://lists.openembedded.org/mt/119510784/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
