Absolutely, please go ahead - it's your bug and your patch, glad to
leave it with you.
For the resend, the convention is a "v2" of the same patch, not a
brand-new submission:
1. Amend the commit to address the feedback:
- Shortlog needs a "<target>: " prefix, e.g.
sudo: fix pam-wheel sed for 1.9.17p2 sudoers format
That clears the patchtest shortlog failure (and it's well under
the length limit).
- Use the bug tag in the form "[YOCTO #16321]" on its own line
instead of "Fixes Yocto Bug #16321". That is the form that
auto-links the bug and that patchtest's bugzilla-entry test looks
for - your v1 was reported as "No bug ID found" because of the
free-text wording.
- Drop the "Upstream-Status:" line. That header belongs in actual
patch files (recipes-*/.../files/*.patch that modify upstream
source), not in the commit message of a recipe (.bb) change, so it
does not apply here.
So the message body would look roughly like:
sudo: fix pam-wheel sed for 1.9.17p2 sudoers format
<your explanation of the root cause>
[YOCTO #16321]
Signed-off-by: Nate Kent <[email protected]>
Tested-by: Siva Balasubramanian <[email protected]>
Feel free to carry over the Tested-by above into v2 - the code is
byte-identical, only the commit message changes.
2. Regenerate with the version bump:
git format-patch -v2 -1
That labels it [PATCH v2]. format-patch won't add the changelog for
you; edit the generated .patch and insert a short "what changed"
note right after the "---" tear line (above the diffstat), so it
stays out of the committed message, e.g.:
---
v2: add "sudo:" shortlog prefix, switch to [YOCTO #16321] tag,
drop Upstream-Status (n/a for a recipe change)
meta/recipes-extended/sudo/sudo_1.9.17p2.bb | 2 +-
(You can also use "git send-email --annotate" and add those lines
there before sending.)
3. Send it with the same git send-email to
[email protected]. Either a fresh send or a
reply works; sending top-level with
--in-reply-to=<[email protected]> (your v1)
keeps the thread linked. v1 can then be marked Superseded on
patchwork.
Happy to look over v2 when it's up.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#239078):
https://lists.openembedded.org/g/openembedded-core/message/239078
Mute This Topic: https://lists.openembedded.org/mt/119864828/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
