On Thu, Jun 18, 2026 at 5:31 PM John Ripple via lists.openembedded.org
<[email protected]> wrote:

> The go-vendor class has a hardcoded destsuffix variable used to unpack
> sources fetched with the go_src_uri function. Change this unpack
> location to take the base package name into account (BP) as is the new
> standard.
>

I have no particular issues with the change, but the commit log doesn't
tell us why this is needed. Was something breaking ? is there any risk
to the assumptions that other classes/recipes/layers may have made
about the location of the unpacked files ?

Bruce



>
> Signed-off-by: John Ripple <[email protected]>
> ---
>  meta/classes/go-vendor.bbclass | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/go-vendor.bbclass
> b/meta/classes/go-vendor.bbclass
> index 6ec6178add..f854d14bdf 100644
> --- a/meta/classes/go-vendor.bbclass
> +++ b/meta/classes/go-vendor.bbclass
> @@ -19,7 +19,7 @@ inherit go-mod
>  def go_src_uri(repo, version, path=None, subdir=None, \
>                  vcs='git', replaces=None, pathmajor=None):
>
> -    destsuffix = "git/src/import/vendor.fetch"
> +    destsuffix = "${BP}/src/import/vendor.fetch"
>      module_path = repo if not path else path
>
>      src_uri = "{}://{};name={}".format(vcs, repo,
> module_path.replace('/', '.'))
> @@ -58,7 +58,8 @@ python do_go_vendor() {
>      if not src_uri:
>          bb.fatal("SRC_URI is empty")
>
> -    default_destsuffix = "git/src/import/vendor.fetch"
> +    base_package = d.getVar('BP')
> +    default_destsuffix = "{}/src/import/vendor.fetch".format(base_package)
>      fetcher = bb.fetch2.Fetch(src_uri, d)
>      go_import = d.getVar('GO_IMPORT')
>      source_dir = d.getVar('S')
>
> 
>
>

-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#239110): 
https://lists.openembedded.org/g/openembedded-core/message/239110
Mute This Topic: https://lists.openembedded.org/mt/119874754/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to