Hi, regarding the tag, Should we add the check in the patchtest as well so it will be catched there? Or in some qa?
Daniel ________________________________ From: Daniel Turull <[email protected]> Sent: Thursday, 25 June 2026 17:43:25 To: Alexander Kanavin <[email protected]> Cc: [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]> Subject: Re: [PATCH 2/3] systemd: upgrade to 261 Ok, I’ll restore it in a v2. I assumed that since it was building and working fine it was not needed. I was not aware of the verification. Best regards Daniel ________________________________ From: Alexander Kanavin <[email protected]> Sent: Thursday, June 25, 2026 5:34 PM To: Daniel Turull <[email protected]> Cc: [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]> Subject: Re: [PATCH 2/3] systemd: upgrade to 261 On Thu, 25 Jun 2026 at 15:42, <[email protected]> wrote: > - Drop redundant tag= from SRC_URI (SRCREV already pins the commit) > AI-Generated: Claude-opus-4.6 > -SRC_URI = > "git://github.com/systemd/systemd.git;protocol=https;branch=${SRCBRANCH};tag=v${PV}" > +SRC_URI = > "git://github.com/systemd/systemd.git;protocol=https;branch=${SRCBRANCH}" I can only assume AI is using outdated knowledge in what tag= is used for, and you didn't double check that. Please restore it. It's used to verify that SRCREV matches the tag, and the recipe isn't accidentally (or deliberately) fetching a random unrelated commit. Alex
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#239580): https://lists.openembedded.org/g/openembedded-core/message/239580 Mute This Topic: https://lists.openembedded.org/mt/119973465/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
