Hilariously, I was thinking I should write a test case and didn’t even think to check there was one already…
Sorry to break your build, v2 coming soon. Ross > On 1 Jul 2026, at 12:28, Mathieu Dubois-Briand > <[email protected]> wrote: > > On Tue Jun 30, 2026 at 4:07 PM CEST, Ross Burton via lists.openembedded.org > wrote: >> Since Linux 5.1 the shebang buffer has been 256 bytes[1], so update the >> check to match. >> >> Also rewrite the test, create a variable for the magic number (that has >> the same name as the kernel #define), don't pointlessly try to decode >> the bytes as UTF-8, and consolidate the test logic to entirely inside >> the try block. >> >> [1] linux 6eb3c3d0a52dc ("exec: increase BINPRM_BUF_SIZE to 256") >> --- > > Hi Ross, > > Thanks for your patch. > > I believe you also need to update the test_sysroot_max_shebang selftest > / sysroot-shebang-test-native recipe: > > 2026-07-01 11:25:35,511 - oe-selftest - INFO - FAIL: > sysroot.SysrootTests.test_sysroot_max_shebang (subunit.RemotedTestCase) > 2026-07-01 11:25:35,511 - oe-selftest - INFO - > ---------------------------------------------------------------------- > 2026-07-01 11:25:35,511 - oe-selftest - INFO - > testtools.testresult.real._StringException: Traceback (most recent call last): > File > "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/sysroot.py", > line 49, in test_sysroot_max_shebang > self.assertTrue(expected in res.output, msg=res.output) > File "/usr/lib/python3.12/unittest/case.py", line 727, in assertTrue > raise self.failureException(msg) > AssertionError: False is not true : NOTE: Reconnecting to bitbake server... > > https://autobuilder.yoctoproject.org/valkyrie/#/builders/35/builds/4183 > https://autobuilder.yoctoproject.org/valkyrie/#/builders/48/builds/4010 > > Thanks, > Mathieu > > -- > Mathieu Dubois-Briand, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#239982): https://lists.openembedded.org/g/openembedded-core/message/239982 Mute This Topic: https://lists.openembedded.org/mt/120047334/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
