Hello Yoann, Thanks for the review.
> Please don't rewrite patch message when backporting. > > Only append backporting info at the end. We depend quite heavily on > patch being similar to upstream patches and modifications like your > makes it hard to check. > > Please send a v2 with the commit message preserved. > https://patchwork.yoctoproject.org/project/oe-core/patch/[email protected]/ Understood, and sorry about that. v2 keeps Karel's upstream commit message verbatim and only appends the backport info at the end (Upstream-Status plus a short note about the dropped LDFLAGS hunk). > Also, I can't find the corresponding commit on oe-core/master. If this is in > util-linux/2.42.x branch, can you tell me what is the commit? > This is not for the oe-core/master. It is already on util-linux 2.42.2, which contains the fix, so nothing is needed there. This backport targets the wrynose branch, which is still on util-linux 2.41.3. I've retagged v2 as [OE-core][wrynose][PATCH v2] The upstream commit is: util-linux master: 5683ed6320e00205146cbb3d0c76462733530eca ("pam_lastlog2: fix libpam linking in autotools build", PR #4358) It was cherry-picked to the util-linux v2.41 stable branch as c8d0af0421f6 and released in 2.41.5, and is present in 2.42.x. v2 now points Upstream-Status at the master commit. One note carried over into the backport: against 2.41.3 only the LIBADD line changes. The upstream commit also removes -lpam from LDFLAGS, but that LDFLAGS reference was added upstream after 2.41.3 and is not present in the wrynose tree, so only the LIBADD hunk applies (and carrying the LDFLAGS hunk would fail to apply). Thanks, Siva
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#240215): https://lists.openembedded.org/g/openembedded-core/message/240215 Mute This Topic: https://lists.openembedded.org/mt/119974830/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
