On Tue, 2026-09-01 at 03:37 +0000, Dora, Sunil Kumar via lists.openembedded.org wrote: > > On 8/31/2026 1:22 AM, Khem Raj via lists.openembedded.org wrote: > > > > On Sun, Aug 30, 2026 at 5:59 AM <[email protected]> > > wrote: > > > -@@ -762,6 +762,7 @@ static Triple::EnvironmentType > > > parseEnvironment(StringRef EnvironmentName) { > > > - .StartsWith("eabihf", Triple::EABIHF) > > > - .StartsWith("eabi", Triple::EABI) > > > - .StartsWith("gnuabin32", Triple::GNUABIN32) > > > -+ .StartsWith("gnun32", Triple::GNUABIN32) > > > - .StartsWith("gnuabi64", Triple::GNUABI64) > > > - .StartsWith("gnueabihft64", Triple::GNUEABIHFT64) > > > - .StartsWith("gnueabihf", Triple::GNUEABIHF) > > > -@@ -1087,6 +1088,7 @@ Triple::Triple(std::string &&Str) : > > > Data(std::move(Str)) { > > > +@@ -755,6 +755,7 @@ static Triple::OSType parseOS(StringRef > > > OSName) { > > > + > > > + static Triple::EnvironmentType parseEnvironment(StringRef > > > EnvironmentName) { > > > + return StringSwitch<Triple::EnvironmentType>(EnvironmentName) > > > ++ .StartsWith("gnuabin32", Triple::GNUABIN32) > > > + #define TRIPLE_ENV(Enum, Name) .StartsWith(Name, Triple::Enum) > > > + #include "llvm/TargetParser/TripleName.def" > > > + .Default(Triple::UnknownEnvironment); > > > +@@ -1106,6 +1107,7 @@ Triple::Triple(std::string &&Str) : > > > Data(std::move(Str)) { > > > Environment = > > > StringSwitch<Triple::EnvironmentType>(Components[0]) > > > .StartsWith("mipsn32", Triple::GNUABIN32) > > > > > > > .def already has an alias mechanism (TRIPLE_VENDOR_ALIAS appears > > in the vendor rework) — ifTRIPLE_ENV_ALIAS exists too, using it for > > gnuabin32 would keep the compat spelling in the table itself > > instead of hand-editingparseEnvironment, which will rebase more > > cleanly next > > TRIPLE_ENV_ALIAS doesn't exist yet, I checked 23.1.0 and current > main. Only the OS and vendor sections have alias macros. > > Since Triple.cpp is the only file that includes TripleName.def, the > patch can add the macro itself the same way the other two sections > do. I tried it here, the alias line sits in the table next to gnun32 > and one extra #define in parseEnvironment replaces the hand edit. > The stack applies clean and llvm builds fine with it. > > Is this what you had in mind? I can fold it into v2. We could also > send TRIPLE_ENV_ALIAS to llvm as a small NFC patch, then this > carries just two table lines going forward.
Can you both please trim quoted replies! I tend to ignore it but trying to find this detail in hundreds of lines was painful. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#244826): https://lists.openembedded.org/g/openembedded-core/message/244826 Mute This Topic: https://lists.openembedded.org/mt/120998123/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
