> -----Original Message----- > From: Yoann Congal <[email protected]> > Sent: Sunday, September 6, 2026 12:30 AM > To: Tatrai, Peter (ext) (FT D EU SK BFS1) <[email protected]>; > [email protected] > Subject: Re: [OE-core] [scarthgap][PATCH] testimage: avoid symlinking missing > qemu boot log > > [You don't often get email from [email protected]. Learn why this is > important at > https://aka.ms/LearnAboutSenderIdentification ] > > On Tue Aug 25, 2026 at 2:56 PM CEST, Peter via lists.openembedded.org Tatrai > wrote: > > From: Peter Tatrai <[email protected]> > > > > When qemu test runs only produce suffixed bootlog variants, the base > > bootlog path may not exist. Guard the symlink creation and log a note. > > > > (From OE-Core rev: 7a6596925cb0eb8dd48a0362a51875cdd60152bc) > > > > Signed-off-by: Peter Tatrai <[email protected]> > > --- > > meta/classes-recipe/testimage.bbclass | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/meta/classes-recipe/testimage.bbclass > > b/meta/classes-recipe/testimage.bbclass > > index 33b1c13f9d..744de5d7de 100644 > > --- a/meta/classes-recipe/testimage.bbclass > > +++ b/meta/classes-recipe/testimage.bbclass > > @@ -395,7 +395,10 @@ def testimage_main(d): > > # Copy additional logs to tmp/log/oeqa so it's easier to find them > > targetdir = os.path.join(get_json_result_dir(d), d.getVar("PN")) > > os.makedirs(targetdir, exist_ok=True) > > - os.symlink(bootlog, os.path.join(targetdir, os.path.basename(bootlog))) > > + if os.path.exists(bootlog): > > + os.symlink(bootlog, os.path.join(targetdir, > > os.path.basename(bootlog))) > > + else: > > + bb.note("testimage: boot log not found at %s" % bootlog) > > os.symlink(d.getVar("BB_LOGFILE"), os.path.join(targetdir, > > os.path.basename(d.getVar("BB_LOGFILE") + "." + > > d.getVar('DATETIME')))) > > > > if not results or not complete: > > Hello, > > "(From OE-Core rev:" usually indicate a cherry pick but here this is not a > direct one. > Commit title/message changed and the master commit contained more diffs that > were not cherry-picked here. > > Modified cherry-picks are fine but modifications should be minimal and the > non-trivial > ones explained. > > Can you send a v2 with the above suggestions? > > Thanks! > -- > Yoann Congal > Smile ECS
Hello Yoann, Thanks for the review. I've sent a v2 addressing your comments: removed the misleading "(From OE-Core rev: ...)" line and added an explanation that this is a partial/minimal backport (only the symlink guard, not the bootlog-variants globbing from the master commit, which doesn't apply to scarthgap). https://lists.openembedded.org/g/openembedded-core/topic/scarthgap_patch_v2/121133618 Regards, Peter
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#245305): https://lists.openembedded.org/g/openembedded-core/message/245305 Mute This Topic: https://lists.openembedded.org/mt/120919493/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
