On 21 Sep 2026, at 11:09, Sana Kazi via lists.openembedded.org
<[email protected]> wrote:
> +set -eux
Why -x?
> +for t in config control midi_event client_event_filter
Hardcoded list. Either put the binaries in a directory so you can just glob
them, or sed the list in from the recipe.
> +EXTRA_OEMAKE:append = " AM_CPPFLAGS=-I${S}/include"
Might be neater, as this is ptest-specific, to pass this do_compile_ptest.
> +do_compile:append() {
This should be do_compile_ptest.
> + sed -i 's/^.*$(MAKE) $(AM_MAKEFLAGS) check-TESTS.*$/ /'
> ${S}/test/lsb/Makefile.in
Explain this sed with a small comment.
> + oe_runmake check
We patch into automake a "buildtest-TESTS” that just builds the tests, use
that instead.
> +do_install_ptest:append() {
> + for f in control client_event_filter namehint
Hard-coded list. You can use makefile-getvar to retrieve the list of tests,
unless you explictly want this subset. If you do want an explicit subset then
you definitely don’t want to replicate it.
> + do
> + install -m 0755 "${B}/test/.libs/$f" "${D}${PTEST_PATH}";
> + done
> +
> + for f in config midi_event
> + do
> + install -m 0755 "${B}/test/lsb/.libs/$f" "${D}${PTEST_PATH}";
> + done
> +}
Don’t install libtool generated binaries by assuming you know where the real
binary is. Instead, use "libtool —mode=install install ${B}/test/$f …”. There
are plenty of examples in oe-core.
Ross
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#247044):
https://lists.openembedded.org/g/openembedded-core/message/247044
Mute This Topic: https://lists.openembedded.org/mt/121354712/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
