On Friday 20 July 2012 00:20:01 Darren Hart wrote: > On 07/19/2012 10:36 PM, Khem Raj wrote: > > From: Denis Carikli <[email protected]> > > > > Without that fix we have the following while compiling compat-wireless. > > > > include/linux/mmzone.h:18:30: fatal error: generated/bounds.h: No such > > file or directory> > > Note that the compat-wireless recipe will be added in another commit. > > > > Signed-off-by: Denis 'GNUtoo' Carikli <[email protected]> > > Signed-off-by: Koen Kooi <[email protected]> > > --- > > > > meta/classes/kernel.bbclass | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass > > index 08b5e61..ce4d7de 100644 > > --- a/meta/classes/kernel.bbclass > > +++ b/meta/classes/kernel.bbclass > > @@ -187,6 +187,9 @@ kernel_do_install() { > > > > cp arch/powerpc/lib/crtsavres.o $kerneldir/arch/powerpc/lib/crtsavres.o > > > > fi > > > > + # Necessary for building modules like compat-wireless. > > + cp include/generated/bounds.h $kerneldir/include/generated/bounds.h > > + > > Hrm... I'm not clear on why this is necessary. I understand why you need > bounds.h... but I don't see why it isn't there already. > > A few lines up we do: > > cp -fR * $kerneldir > > Which should cover include/generated/bounds.h... > > Perhaps "make -C $kerneldir _mrproper_scripts" clears that out... Ah, > yes, that seems to be the case. Grumble. > > OK, > > Signed-off-by: Darren Hart <[email protected]>
Having established why this is needed, could the commit message and/or comment clearly state the reason so that there's something to refer to in future? Thanks, Paul -- Paul Eggleton Intel Open Source Technology Centre _______________________________________________ Openembedded-core mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
