On 08/06/2012 11:21 AM, Phil Blundell wrote: > On Mon, 2012-08-06 at 11:10 -0700, Darren Hart wrote: >> On 08/05/2012 08:54 AM, Javier Martinez Canillas wrote: >>> It is considered good practice to use the build system provided >>> variables instead of directly specify hardcoded paths. >> >> The firmware location is explicitly set because this is where the Linux >> kernel requires it to be. > > Is that actually true? I thought the kernel just supplied the leafname > that it wanted and the knowledge about what directory to search was > encoded in the hotplug helper scripts.
I was sure it was true at the time, but trying to get a reference from the source suggests I was mistaken. According to Documentation/firmware_class/README, the hotplug script is responsible for locating the firmware by basename and catting it to a sysfs file for the kernel to then read. While there are several hardcoded references to "/lib/firmware" (comments, installation of in-kernel firmware, etc.), none of these seem to be related to loading firmware installed via linux-firmware. So... the question I guess is: does hotplug know to look in ${base_libdir}/firmware. But the larger concern, is that all these changes appear to have been done via search/replace without any functional testing of the result. -- Darren > >> This patch will break firmware loading. > > That might well be the case, though, unless the scripts have also been > patched to respect ${base_libdir}. > > And, notwithstanding all the above, it's not entirely obvious that > ${base_libdir} is semantically the right variable for things that aren't > libraries. How does the udev recipe represent the patch to /lib/udev? > > p. > > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > -- Darren Hart Intel Open Source Technology Center Yocto Project - Technical Lead - Linux Kernel _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core