On Tue, Aug 21, 2012 at 1:30 PM, Khem Raj <[email protected]> wrote: > On Tue, Aug 21, 2012 at 11:10 AM, McClintock Matthew-B29882 > <[email protected]> wrote: >> On Tue, Aug 21, 2012 at 1:06 PM, Khem Raj <[email protected]> wrote: >>> On Tue, Aug 21, 2012 at 10:59 AM, McClintock Matthew-B29882 >>> <[email protected]> wrote: >>>> On Tue, Aug 21, 2012 at 12:54 PM, Khem Raj <[email protected]> wrote: >>>>> On Tue, Aug 21, 2012 at 9:20 AM, Matthew McClintock <[email protected]> >>>>> wrote: >>>>>> + >>>>>> +do_configure_prepend (){ >>>>>> + if ! grep O_CLOEXEC -r ${includedir_native}/bits/fcntl.h; then >>>>>> + export CFLAGS="$CFLAGS -D O_CLOEXEC=0" >>>>>> + fi >>>>>> +} >>>>> >>>>> >>>>> IMO It would be safer to create a patch for kmod itself where you >>>>> define O_CLOEXEC if it >>>>> was not defined before. The above seems a bit risky >>>> >>>> Why is it risky? I only wanted to do this for affected systems. There >>>> is not an easy way to do this with a patch, unless of course I apply >>>> the patch manually. >>> >>> manually gripping at the host installation and then if O_CLOEXEC might >>> be in comments >> >> How about grep define.*O_CLOEXEC -r ${includedir_native}/bits/fcntl.h >> >>> and furthermore it if it comes from fcntl.h which is not where you are >>> looking for >> >> I am grepping this file though? > > I would go into the specific file where its asking for O_CLOEXEC > > and add > > #ifndef O_CLOEXEC > # define O_CLOEXEC 0 > #endif > > and be done with it
Well this is seemingly the same way of doing it, just looks like you always want it applied? I don't think it should always be applied. If this was it takes to get the build fix in, then I will do it... please confirm what will be accepted. -M > >> >>> there are few variables like that where its impacting more than >>> affected systems. >> >> I don't follow... >> >> -M > > _______________________________________________ > Openembedded-core mailing list > [email protected] > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core _______________________________________________ Openembedded-core mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
