On 08/31/2012 10:01 AM, Björn Stenberg wrote:
Saul Wold wrote:
You new patches still need patch headers with Upstream-Status and
Signed-off-by tags.

Ouch, sorry about that. I added Signed-off but forgot upstream. I'll be more 
careful next time.

Just to be clear these need to be in your busybox patches not the commit message for the overall patch to OE-Core, I hope that makes sense.

In these two files:
meta/recipes-extended/bash/bash-4.2/build-tests.patch
meta/recipes-extended/bash/bash-4.2/test-output.patch


Should this be a DISTRO or IMAGE FEATURE? I can see potential
arguments for both sides, what was your thinking on choosing IMAGE
over DISTRO?

I chose IMAGE since that is how the -dbg and -dev package groups are enabled, 
and -ptest is modeled after them. Also we have the EXTRA_IMAGE_FEATURES setting 
that can be used to enable this temporarily while I don't know if we have 
anything similar for DISTRO_FEATURES?

That makes sense also, I was thinking along the same lines, just wanted to get your reasoning captured.

Thanks
        Sau!



_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Reply via email to