On 10/26/2012 05:44 PM, Paul Eggleton wrote:
On Friday 26 October 2012 17:37:17 Mihai Lindner wrote:
Check for lsb_release command (package name should be lsb-release for
most package managers) to avoid "Unknown" Linux distributions, untested
distro warnings and "Unknown" dir in ./sstate-cache/
Also add lsb-release in host's software needs, Fedora and CentOS for now.

Signed-off-by: Mihai Lindner <[email protected]>
---
  documentation/poky.ent      | 4 ++--
  meta/classes/sanity.bbclass | 2 +-
  2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/documentation/poky.ent b/documentation/poky.ent
index 8e0af71..ae8e70e 100644
--- a/documentation/poky.ent
+++ b/documentation/poky.ent
@@ -50,8 +50,8 @@
  <!ENTITY OE_INIT_FILE "oe-init-build-env">
  <!ENTITY UBUNTU_HOST_PACKAGES_ESSENTIAL "awk wget git-core diffstat unzip
texinfo build-essential chrpath"> <!ENTITY FEDORA_HOST_PACKAGES_ESSENTIAL
"awk make wget tar bzip2 gzip python unzip perl patch diffutils diffstat
git -cpp gcc gcc-c++ eglibc-devel texinfo chrpath ccache">
+cpp gcc gcc-c++ eglibc-devel texinfo chrpath ccache lsb-release">
  <!ENTITY OPENSUSE_HOST_PACKAGES_ESSENTIAL "python gcc gcc-c++ git chrpath
make wget diffstat texinfo python-curses"> <!ENTITY
CENTOS_HOST_PACKAGES_ESSENTIAL "gawk make wget tar bzip2 gzip python unzip
perl patch diffutils diffstat git -cpp gcc gcc-c++ glibc-devel texinfo
chrpath">
+cpp gcc gcc-c++ glibc-devel texinfo chrpath lsb-release">

diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 3806bc5..f0cc11c 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -2,7 +2,7 @@
  # Sanity check the users setup for common misconfigurations
  #

-SANITY_REQUIRED_UTILITIES ?= "patch diffstat makeinfo git bzip2 tar gzip
gawk chrpath wget cpio" +SANITY_REQUIRED_UTILITIES ?= "bzip2 chrpath cpio
diffstat gawk git gzip lsb_release makeinfo patch tar wget"

  python check_bblayers_conf() {
      bblayers_fn = os.path.join(d.getVar('TOPDIR', True),
'conf/bblayers.conf')

I don't particularly like this, because on some distros LSB comes as one
package which pulls in a whole bunch of unnecessary things for a headless
server. I think we need an alternative fix for this for the cases where
lsb_release is not available.

Cheers,
Paul


You're right Paul. Thanks. I'll check for other solutions.
Please ignore this patch.

2/2 should still apply though.

Cheers,

--
Mihai Lindner

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Reply via email to