On Fri, Nov 23, 2012 at 09:52:28AM +0000, Phil Blundell wrote:
> On Fri, 2012-11-23 at 10:09 +0100, Martin Jansa wrote:
> > -TARGET_LD_KERNEL_ARCH += "${@bb.utils.contains("TUNE_FEATURES", "armv4",
> > "--fix-v4bx", "", d)}"
> > +TARGET_LD_KERNEL_ARCH += "${@bb.utils.contains("DEFAULTTUNE", "armv4",
> > "--fix-v4bx", "", d)}"
>
> Testing DEFAULTTUNE doesn't really seem like the right thing. Not that
> I am any expert in the twisty maze of tune variables, but I would have
> thought this should be:
>
> TARGET_LD_KERNEL_ARCH += "${@bb.utils.contains("TUNE_FEATURES", "thumb", "",
> "--fix-v4bx", d)}"Depends if we want to apply it on e.g. armv5te device without thumb in TUNE_FEATURES. > Or maybe it could just be fixed in the kernel, since its own build > system already knows whether Thumb is available or not. True, but then we need to fix every kernel recipe and because it took me quite long time to find commit which caused it, I fear that it will reappear in future when some layer adds kernel recipe without such fix. Cheers, -- Martin 'JaMa' Jansa jabber: [email protected]
signature.asc
Description: Digital signature
_______________________________________________ Openembedded-core mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
