On 12-12-14 12:27 AM, [email protected] wrote:
From: Tom Zanussi<[email protected]>

If do_make_scripts() executes before do_unpack()/do_patch(), the build
fails because it can't cd into the workdir of a recipe using this
class, so make sure do_make_scripts() doesn't run before the package
has been unpacked and patched.

I've never seen the problem myself, but having a more tightly defined
ordering for the task is a good thing in my books.

Since you aren't breaking the working use case, I have no objection.

So I'll throw out a fancy: Reviewed-by: Bruce Ashfield <[email protected]>

Cheers,

Bruce


Fixes [YOCTO #3589].

Signed-off-by: Tom Zanussi<[email protected]>
---
  meta/classes/module.bbclass |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta/classes/module.bbclass b/meta/classes/module.bbclass
index e8d32eb..ebb0880 100644
--- a/meta/classes/module.bbclass
+++ b/meta/classes/module.bbclass
@@ -3,7 +3,7 @@ DEPENDS += "virtual/kernel"

  inherit module-base

-addtask make_scripts before do_compile
+addtask make_scripts after do_patch before do_compile
  do_make_scripts[lockfiles] = "${TMPDIR}/kernel-scripts.lock"
  do_make_scripts[deptask] = "do_populate_sysroot"



_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Reply via email to