On Sat, 2013-01-12 at 06:22 -0500, Robert P. J. Day wrote:
> this snippet from image_types.bbclass:
> 
>     if "elf" in alltypes:
>         alltypes.remove("elf")
>         if "cpio.gz" not in alltypes:
>                 alltypes.append("cpio.gz")
>         alltypes.append("elf")
> 
>     # Filter out all the compressed images from types
>     for type in alltypes:
>     ... snip ...
> 
> i was going to trivially fix that comment (it's now "alltypes", not
> "types"), but i was distracted by the code above that -- what the heck
> is going on there?  what's the rationale for removing elf, then adding
> cpio.gz and elf back on at the end?  if someone can clarify that, i
> can add that as more comment, as well as a few other tweaks in that
> file for more documentation for anyone reading TFS.  thanks.

Order is important. The elf image depends on the cpio.gz image already
having been created so a) it must be created and b) it must happen
before elf.

Cheers,

Richard




_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Reply via email to