Hello Lei,

Please note that I answered your question, but this patch was sent in for 
review.
Other people might consider your questions as comments, and as such, this patch 
will not get merged.

Regards,
Cristian

From: lei yang [mailto:[email protected]]
Sent: Tuesday, February 05, 2013 4:01 AM
To: Iorga, Cristian
Cc: [email protected]
Subject: Re: [OE-core] [PATCH] net-tools: upgrade to v1.60-24.2



On Monday, February 4, 2013, Iorga, Cristian wrote:
See my answers below.

-----Original Message-----
From: Lei Yang [mailto:[email protected]<javascript:;>]
Sent: Sunday, February 03, 2013 4:15 AM
To: Iorga, Cristian
Cc: [email protected]<javascript:;>
Subject: Re: [OE-core] [PATCH] net-tools: upgrade to v1.60-24.2



Sent from my iPhone

On 2013-2-1, at 23:09, Cristian Iorga <[email protected]<javascript:;>> 
wrote:

> Signed-off-by: Cristian Iorga <[email protected]<javascript:;>>
> ---
> .../net-tools-config.h                                           |    0
> .../net-tools-config.make                                        |    0
> .../net-tools/{net-tools_1.60-23.bb<http://net-tools_1.60-23.bb> => 
> net-tools_1.60-24.2.bb<http://net-tools_1.60-24.2.bb>}   |    6 +++---
> 3 files changed, 3 insertions(+), 3 deletions(-) rename
> meta/recipes-extended/net-tools/{net-tools-1.60-23 =>
> net-tools-1.60-24.2}/net-tools-config.h (100%) rename
> meta/recipes-extended/net-tools/{net-tools-1.60-23 =>
> net-tools-1.60-24.2}/net-tools-config.make (100%) rename
> meta/recipes-extended/net-tools/{net-tools_1.60-23.bb<http://net-tools_1.60-23.bb>
>  =>
> net-tools_1.60-24.2.bb<http://net-tools_1.60-24.2.bb>} (94%)
>
> diff --git
> a/meta/recipes-extended/net-tools/net-tools-1.60-23/net-tools-config.h
> b/meta/recipes-extended/net-tools/net-tools-1.60-24.2/net-tools-config
> .h
> similarity index 100%
> rename from
> meta/recipes-extended/net-tools/net-tools-1.60-23/net-tools-config.h
> rename to
> meta/recipes-extended/net-tools/net-tools-1.60-24.2/net-tools-config.h
> diff --git
> a/meta/recipes-extended/net-tools/net-tools-1.60-23/net-tools-config.m
> ake
> b/meta/recipes-extended/net-tools/net-tools-1.60-24.2/net-tools-config
> .make
> similarity index 100%
> rename from
> meta/recipes-extended/net-tools/net-tools-1.60-23/net-tools-config.mak
> e rename to
> meta/recipes-extended/net-tools/net-tools-1.60-24.2/net-tools-config.m
> ake diff --git 
> a/meta/recipes-extended/net-tools/net-tools_1.60-23.bb<http://net-tools_1.60-23.bb>
> b/meta/recipes-extended/net-tools/net-tools_1.60-24.2.bb<http://net-tools_1.60-24.2.bb>
> similarity index 94%
> rename from 
> meta/recipes-extended/net-tools/net-tools_1.60-23.bb<http://net-tools_1.60-23.bb>
> rename to 
> meta/recipes-extended/net-tools/net-tools_1.60-24.2.bb<http://net-tools_1.60-24.2.bb>
> index bc61d21..4040e1a 100644
> --- 
> a/meta/recipes-extended/net-tools/net-tools_1.60-23.bb<http://net-tools_1.60-23.bb>
> +++ 
> b/meta/recipes-extended/net-tools/net-tools_1.60-24.2.bb<http://net-tools_1.60-24.2.bb>
> @@ -5,7 +5,7 @@ BUGTRACKER = "http://bugs.debian.org/net-tools";
> LICENSE = "GPLv2+"
> LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b \
>                     
> file://ifconfig.c;beginline=11;endline=15;md5=d1ca372080ad5401e23ca0afc35cf9ba<file:///\\COPYING;md5=8ca43cbc842c2336e835926c2166c28b%20\%0b%3e%20
>  %20 %20 %20 %20 %20 %20 %20 %20 %20 
> %20file:\ifconfig.c;beginline=11;endline=15;md5=d1ca372080ad5401e23ca0afc35cf9ba>"
> -PR = "r3"
> +PR = "r0"
>

Is there a reason to change it back to r0
Yes, because an upgrade has been done.

I  thought it should aways bump,seems if we update the PV, it will be reset to 
r0. Right?

Yes.


Lei

> SRC_URI = 
> "${DEBIAN_MIRROR}/main/n/net-tools/net-tools_1.60.orig.tar.gz;name=tarball \
>
> ${DEBIAN_MIRROR}/main/n/net-tools/${BPN}_${PV}.diff.gz;apply=no;name=p
> atch \

Not sure why it not apply but not remove it.
Sorry, I don't understand your comment.
This package is distributed as a "base" tarball + patches to higher versions.
Hence, I don't understand your comment.

I mean apply=no, here

Lei


I

Lei

> @@ -17,8 +17,8 @@ S = "${WORKDIR}/net-tools-1.60"
> SRC_URI[tarball.md5sum] = "ecaf37acb5b5daff4bdda77785fd916d"
> SRC_URI[tarball.sha256sum] = 
> "ec67967cf7b1a3a3828a84762fbc013ac50ee5dc9aa3095d5c591f302c2de0f5"
>
> -SRC_URI[patch.md5sum] = "2412e55c20308d5fbd28bfadd18c075f"
> -SRC_URI[patch.sha256sum] = 
> "d678b3ea97d6c7ca548918994642bfc6b5511ab02f3a5881dfcca00c88bfd73b"
> +SRC_URI[patch.md5sum] = "524658bb8df5ff92c4a991f5edcaf240"
> +SRC_URI[patch.sha256sum] = 
> "170cc024fcb34329f4c25fd88b5f160a06be5d6d3eaf0bc976650fd1b1a6235d"
>
> inherit gettext
>
> --
> 1.7.10.4
>
>
> _______________________________________________
> Openembedded-core mailing list
> [email protected]<javascript:;>
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Reply via email to