This one looks reasonable to me. Be sure to add your patch header to the patch itself, add your Signed-off-by, and submit upstream for feedback before merging with oe-core.
-- Darren On 05/07/2013 02:48 AM, Robert Yang wrote: > The max length of debugfs argument is 256 which is too short, the > arguments are two paths, the PATH_MAX is 4096 according to > /usr/include/linux/limits.h, use 2048 (4096 / 2) is a reasonable value. > > [YOCTO #3848] > > Signed-off-by: Robert Yang <[email protected]> > --- > .../e2fsprogs-1.42.7/debugfs-too-short.patch | 28 > ++++++++++++++++++++ > .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb | 1 + > 2 files changed, 29 insertions(+) > create mode 100644 > meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/debugfs-too-short.patch > > diff --git > a/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/debugfs-too-short.patch > b/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/debugfs-too-short.patch > new file mode 100644 > index 0000000..db6814d > --- /dev/null > +++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.7/debugfs-too-short.patch > @@ -0,0 +1,28 @@ > +debugfs.c: the max length of debugfs argument is too short > + > +The max length of debugfs argument is 256 which is too short, the > +arguments are two paths, the PATH_MAX is 4096 according to > +/usr/include/linux/limits.h, use 2048 (4096 / 2) is a reasonable value. > + > +Upstream-Status: Pending > + > +Signed-off-by: Robert Yang <[email protected]> > +--- > + debugfs/debugfs.c | 2 +- > + 1 file changed, 1 insertion(+), 1 deletion(-) > + > +diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c > +--- a/debugfs/debugfs.c > ++++ b/debugfs/debugfs.c > +@@ -2282,7 +2282,7 @@ void do_dump_mmp(int argc EXT2FS_ATTR((unused)), char > *argv[]) > + static int source_file(const char *cmd_file, int ss_idx) > + { > + FILE *f; > +- char buf[256]; > ++ char buf[2048]; > + char *cp; > + int exit_status = 0; > + int retval; > +-- > +1.7.11.2 > + > diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb > b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb > index 3a4f5a8..898ee88 100644 > --- a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb > +++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.42.7.bb > @@ -4,6 +4,7 @@ PR = "r0" > > SRC_URI += "file://acinclude.m4 \ > file://remove.ldconfig.call.patch \ > + file://debugfs-too-short.patch \ > " > > SRC_URI[md5sum] = "a1ec22ef003688dae9f76c74881b22b9" > -- Darren Hart Intel Open Source Technology Center Yocto Project - Technical Lead - Linux Kernel _______________________________________________ Openembedded-core mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
