Hi,

When using manual ip the ipv4_config structure has all fields populated and 
this condition
is skipped. The only case when the data structure fields are NULL is when we 
have
DHCP settings and for different reasons network configurations are not done. In 
this
case, connman automatically renews the ipv4 configurations in less than a 
minute.
Ethernet manual configuration behavior remains unchanged after this fix.

Thanks,
Ema
________________________________________
From: Burton, Ross [[email protected]]
Sent: Friday, May 17, 2013 1:52 PM
To: Ciobanu, Emilia Maria Silvia
Cc: [email protected]
Subject: Re: [OE-core] [PATCH] connman-gnome: fixed DHCP segfault

On 17 May 2013 11:32, Emilia Ciobanu
<[email protected]> wrote:
> +-      if (g_str_equal(ipv4_config.method, "dhcp") == TRUE)
> ++      if (!ipv4_config.method || g_str_equal(ipv4_config.method, "dhcp") == 
> TRUE)

Is this really the right behaviour if IPv4.Method isn't set?

Ross

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Reply via email to