On Jun 29, 2013, at 8:31 AM, Martin Jansa <[email protected]> wrote:
> On Sat, Jun 29, 2013 at 07:11:35AM -0700, Khem Raj wrote: >> >> On Jun 28, 2013, at 10:38 PM, Martin Jansa <[email protected]> wrote: >> >>> On Fri, Jun 28, 2013 at 03:03:39PM -0700, Khem Raj wrote: >>>> >>>> generate-manifest-3.3.py: Add script to generate python 3.3 manifests >>>> python-3.3-manifest: Add python3 manifest file >>> >>>> classes: Add distutils for python3 >>>> setuptools.bbclass: Use python-distribute instead of >>>> python-setuptools >>>> distutils3.bbclass: Port the distutils class fix to handle filenames >>>> with spaces >>>> setuptools3.bbclass: Remove useless multiline comment >>>> distutils: Introduce PYTHON_ABI variable >>>> distutils3: Do build_ext as separate step during compile >>> >> >>> I think these 2 groups could be squashed together for easier review, but >> >> do you mean create just two patches out of those ? > > Yes > >>> otherwise great work, thanks for doing it! >>> >>> I'll add them to jenkins a bit later when I get some better build that >>> what we have now. >> >> They were added in order that the build keeps working with every commit for >> helping bisects on tree later > > I meant that e.g. > classes: Add distutils for python3 > introduces setuptools3.bbclass and > setuptools3.bbclass: Remove useless multiline comment > just 3 commits later fixes that, the same with the left-over commit I > mentined in other thread which was also resolved by some follow up > commit, with all new .bbclasses together I would read them just once. > Thanks Martin and Paul for reviewing and trying out the patches Finally I have now addressed all the comments/feedback that was provided for this patch set. The pull tree is now updated to latest. Take a look and install if its ok -Khem _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
