On Fri, 2013-08-23 at 10:02 +0800, Robert Yang wrote: > On 08/23/2013 01:24 AM, Darren Hart wrote: > > On Thu, 2013-08-22 at 09:13 -0400, Robert Yang wrote: > >> do_write doesn't fully set up the first extent header on a new > >> inode, so if we write a 0-length file, and don't write any data > >> to the new file, we end up creating something that looks corrupt > >> to kernelspace: > >> > >> EXT4-fs error (device loop0): ext4_ext_check_inode:464: inode #12: comm > >> ls: bad header/extent: invalid magic - magic 0, entries 0, max 0(0), > >> depth 0(0) > >> > >> Do something similar to ext4_ext_tree_init() here, and > >> fill out the first extent header upon creation to avoid this. > >> > >> [YOCTO #3848] > >> > >> Signed-off-by: Robert Yang <[email protected]> > >> --- > >> .../e2fsprogs-1.42.8/debugfs-extent-header.patch | 47 > >> ++++++++++++++++++++ > >> .../recipes-devtools/e2fsprogs/e2fsprogs_1.42.8.bb | 2 + > > > >> +Upstream-Status: Backport > > > > Should we backport? Or should we just update the revision we use? > > > > Yes, I think so, Ted said that he had merge this patch a few days ago, but > I didn't see where is it, I pulled this patch from the linux ext mailing > list.
OK, yeah, this is fine. It will be nice to rebase at some point in the future and drop these patches, but we have to do that anyway, so this is fine in my opinion. Acked-by: Darren Hart <[email protected]> -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
