On Wed, 2013-09-11 at 14:30 +0200, Peter Kjellerstedt wrote: > > -----Original Message----- > > From: Darren Hart [mailto:[email protected]] > > Sent: den 10 september 2013 17:38 > > To: Peter Kjellerstedt > > Cc: [email protected] > > Subject: Re: [OE-core] [PATCH 1/1] bb-matrix-plot: Use interpolation > > for sparse data > > > > On Tue, 2013-09-10 at 14:20 +0200, Peter Kjellerstedt wrote: > > > If not every combination of BB_NUMBER_THREADS and PARALLEL_MAKE have > > > been tested by bb-matrix.sh, e.g., by using BB_RANGE="04 08 10 12 16" > > > and PM_RANGE="04 08 10 12 16", then the graph that gnuplot generates by > > > default looks very jagged due to the missing data points. By using > > > splines to interpolate the missing data the graph looks a lot better. > > > > > > This should not change graphs where all data points are available in any > > > way, only improve sparse graphs. > > > > > > Signed-off-by: Peter Kjellerstedt <[email protected]> > > > --- > > > scripts/contrib/bb-perf/bb-matrix-plot.sh | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/scripts/contrib/bb-perf/bb-matrix-plot.sh > > > b/scripts/contrib/bb-perf/bb-matrix-plot.sh > > > index 87e8cb1..136a255 100755 > > > --- a/scripts/contrib/bb-perf/bb-matrix-plot.sh > > > +++ b/scripts/contrib/bb-perf/bb-matrix-plot.sh > > > @@ -115,7 +115,7 @@ set xlabel "$XLABEL" > > > set ylabel "$YLABEL" > > > set style line 100 lt 5 lw 1.5 > > > $PM3D_FRAGMENT > > > -set dgrid3d $PM_CNT,$BB_CNT > > > +set dgrid3d $PM_CNT,$BB_CNT splines > > > > > > Saweet! I just couldn't figure that one out for some reason. Thank you, > > thank you, thank you! > > > > Please note the gnuplot 4.4 dependency in the patch commit message > > though. Also, what happens if an older gnuplot is used? Does it fail or > > revert to the old behavior? If it fails, can we check for 4.4 and use > > splines if available? > > I actually tried it now using gnuplot 4.2.2, and the script > already uses a couple of features that require gnuplot 4.4. > The script can be fixed to support gnuplot 4.2 (by adding a > test for the gnuplot version and then modifying the input to > gnuplot accordingly), but since nobody has complained so far, > I would suggest just leaving it as is...
Agreed. Thank you Peter. Acked-by: Darren Hart <[email protected]> -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
