Hi Muhammad,

On 13.09.2013 14:50, Shakeel, Muhammad wrote:
From: Muhammad Shakeel <muhammad_shak...@mentor.com>

- --enable-threads and --enable-fake are obsolete, unrecognized options
now.
- --enable-bluetooth,wifi,ofono just build these technologies as plugins
and these plugins need to be installed explicitly. Our intention here
is to make these technologies available by default, if enabled. For
this we need --enable-bluetooth,wifi,ofono=builtin.
- If bluetooth is getting disabled then disable dundee as well, which
is enabled by default.

Signed-off-by: Muhammad Shakeel <muhammad_shak...@mentor.com>
---
  meta/recipes-connectivity/connman/connman.inc |    8 +++-----
  1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/meta/recipes-connectivity/connman/connman.inc 
b/meta/recipes-connectivity/connman/connman.inc
index 37ce3ec..71ecce2 100644
--- a/meta/recipes-connectivity/connman/connman.inc
+++ b/meta/recipes-connectivity/connman/connman.inc
@@ -21,14 +21,12 @@ EXTRA_OECONF += "\
      ac_cv_path_WPASUPPLICANT=${sbindir}/wpa_supplicant \
      ac_cv_path_PPPD=${sbindir}/pppd \
      --enable-debug \
-    --enable-threads \
      --enable-loopback \
      --enable-ethernet \
      --enable-tools \
      --enable-test \
      --disable-polkit \
      --enable-client \
-    --enable-fake \

Ack to this part, those options can be removed.

      ${@base_contains('DISTRO_FEATURES', 'systemd', 
'--with-systemdunitdir=${systemd_unitdir}/system/', '--with-systemdunitdir=', 
d)} \
  "

@@ -42,9 +40,9 @@ PACKAGECONFIG ??= "wispr \
  # local.conf or distro config
  # PACKAGECONFIG_append_pn-connman = " openvpn vpnc l2tp pptp"

-PACKAGECONFIG[wifi] = "--enable-wifi, --disable-wifi, wpa-supplicant"
-PACKAGECONFIG[bluetooth] = "--enable-bluetooth, --disable-bluetooth, bluez4"
-PACKAGECONFIG[3g] = "--enable-ofono, --disable-ofono, ofono"
+PACKAGECONFIG[wifi] = "--enable-wifi=builtin, --disable-wifi, wpa-supplicant"
+PACKAGECONFIG[bluetooth] = "--enable-bluetooth=builtin, --disable-bluetooth 
--disable-dundee, bluez4"
+PACKAGECONFIG[3g] = "--enable-ofono=builtin, --disable-ofono, ofono"

There is no need to say builtin here as that is the default and those plugins are always builtin anyways.

About the dundee disabling, it would probably be better to have this check in upstream connman. This would mean that if bluetooth is disabled, then dundee would be automatically disabled (tweak Makefile.plugins in ConnMan).
Could you send patch for this to connman ml?


  PACKAGECONFIG[tist] = "--enable-tist,--disable-tist,"
  PACKAGECONFIG[openvpn] = "--enable-openvpn 
--with-openvpn=${sbindir}/openvpn,--disable-openvpn,,openvpn"
  PACKAGECONFIG[vpnc] = "--enable-vpnc 
--with-vpnc=${sbindir}/vpnc,--disable-vpnc,,vpnc"



Cheers,
Jukka

_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Reply via email to