On Tuesday 17 September 2013 14:07:01 Paul Barker wrote:
> On 17 September 2013 12:22, JC <[email protected]> wrote:
> > From: JC Verdie <[email protected]>
> >
> > Signed-off-by: JC Verdie <[email protected]>
>
> Couple of tips on the commit message:
>
> First line of the commit message should be "libao: add version 1.1.0"
> or similar and should be and fairly short, put the link to the source
> within the body of the commit message and possibly reference the
> author of the recipe you're copying this from if you can.
Right. A few other things:
1) Since nothing in OE-Core needs this at the moment, this should really be
added to meta-multimedia (within the meta-openembedded repository) and sent to
the openembedded-devel mailing list marked with [meta-multimedia] in the
subject.
2) Please use ${BP} in SRC_URI rather than ${P} so that multilib builds can
work
3) It would be nice to have SUMMARY and HOMEPAGE set in the recipe (and
possibly also DESCRIPTION if you have a longer description).
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
