On 10 October 2013 13:23, Ewan LE BIDEAU-CANEVET
<[email protected]> wrote:

Apologies if the formatting is messed up here, the patch wasn't sent
with -M so I had to re-generate the diff and manually add quotation
marks.

> SRC_URI = "http://wayland.freedesktop.org/releases/${BPN}-${PV}.tar.xz \
>            file://install-examples.patch \
>-           file://weston-launch-shell.patch \
>-           file://groups.patch \
>            file://weston.png \
>            file://weston.desktop"

When removing patches, please say why.

>-DEPENDS += "wayland virtual/mesa virtual/egl pango"
>-
>+DEPENDS += "wayland mesa virtual/egl pango"

You've probably inadvertently reverted a fix here: the dependency
should be virtual/mesa.

>+BBCLASSEXTEND = "native"

Why do you need a native weston?

>-                   ${@base_contains('DISTRO_FEATURES', 'pam', 'launch', '', 
>d)} \
>-PACKAGECONFIG[kms] = "--enable-drm-compositor,--disable-drm-compositor,drm 
>udev mesa mtdev"
>+PACKAGECONFIG[kms] = "--enable-drm-compositor 
>--enable-weston-launch,--disable-drm-compositor --disable-weston-launch,drm 
>udev mesa mtdev libpam"
>-# weston-launch
>-PACKAGECONFIG[launch] = 
>"--enable-weston-launch,--disable-weston-launch,libpam"
>+

Another revert.

This is why we ask for patches with -M: it makes it easy to see what
the changes are.  In this case there are several fixes lost that were
made in between your original change and the re-submission

Ross
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Reply via email to