On 10/17/2013 06:11 PM, Phil Blundell wrote:
On Thu, 2013-10-17 at 18:03 +0800, Ming Liu wrote:
+pkg_postinst_${PN} () {
+ touch $D${sysconfdir}/shells
+ grep -q "${bindir}/screen" $D${sysconfdir}/shells || echo ${bindir}/screen
>> $D${sysconfdir}/shells
+}
Is that "touch" really desirable? It seems as though screen ought not
really to be creating /etc/shells if it isn't there already,
No, it's supposed to be created if /etc/shells doesn't exist already,
otherwise, how could we echo text to it?
and
probably ought not to be updating the timestamp if it isn't actually
changing the file either.
Yes, it may happen that the timestamp be updated even the it isn't
actually changing the file, but only for upgrade case, and I think it's
not a big deal. Actually I copied this piece of script from bash recipe,
it's doing the same thing there.
//Ming Liu
p.
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
