On Mon, 2013-10-21 at 00:34 +0200, Andrea Adami wrote: > When overriding EXTRA_IMAGE_CMD_jffs2 = "--pad=foo ..." > we are passing a malformed option to sumtool: > > sumtool: option '--pad' doesn't allow an argument > > Fix this by declaring a separate variable for the purpose. > > Signed-off-by: Andrea Adami <[email protected]> > --- > meta/classes/image_types.bbclass | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/meta/classes/image_types.bbclass > b/meta/classes/image_types.bbclass > index b8779e0..21391e8 100644 > --- a/meta/classes/image_types.bbclass > +++ b/meta/classes/image_types.bbclass > @@ -141,8 +141,8 @@ XZ_INTEGRITY_CHECK ?= "crc32" > XZ_THREADS ?= "-T 0" > > IMAGE_CMD_jffs2 = "mkfs.jffs2 --root=${IMAGE_ROOTFS} --faketime > --output=${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.jffs2 ${EXTRA_IMAGECMD}" > -IMAGE_CMD_sum.jffs2 = "${IMAGE_CMD_jffs2} && sumtool -i > ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.jffs2 \ > - -o ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.sum.jffs2 ${EXTRA_IMAGECMD}" > +IMAGE_CMD_sum.jffs2 = "mkfs.jffs2 --root=${IMAGE_ROOTFS} --faketime > --output=${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.jffs2 > ${EXTRA_IMAGECMD_jffs2} \ > + && sumtool -i ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.jffs2 -o > ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.sum.jffs2 ${EXTRA_IMAGECMD}" > > IMAGE_CMD_cramfs = "mkfs.cramfs ${IMAGE_ROOTFS} > ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.cramfs ${EXTRA_IMAGECMD}" > > @@ -212,6 +212,7 @@ inherit siteinfo > JFFS2_ENDIANNESS ?= "${@base_conditional('SITEINFO_ENDIANNESS', 'le', '-l', > '-b', d)}" > JFFS2_ERASEBLOCK ?= "0x40000" > EXTRA_IMAGECMD_jffs2 ?= "--pad ${JFFS2_ENDIANNESS} > --eraseblock=${JFFS2_ERASEBLOCK} --no-cleanmarkers" > +EXTRA_IMAGECMD_sum.jffs2 ?= "--pad ${JFFS2_ENDIANNESS} > --eraseblock=${JFFS2_ERASEBLOCK} --no-cleanmarkers" > > # Change these if you want default mkfs behavior (i.e. create minimal inode > number) > EXTRA_IMAGECMD_ext2 ?= "-i 8192"
This patch is very confused. You say sumtool doesn't take a --pad option, yet "EXTRA_IMAGECMD_sum.jffs" which is presumably used with sumtool does have the option. We need to make this clearer and I don't think this patch does that, I'm not even sure it works... Cheers, Richard _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
