On 2013-11-14 06:07, [email protected] wrote:
From: Chen Qi <[email protected]>
TMPDIR must be an absolute path, otherwise, the build will fail.
Special characters in TMPDIR will also cause build failures.
This patch enables checking for the validity of TMPDIR.
Signed-off-by: Chen Qi <[email protected]>
---
meta/classes/sanity.bbclass | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 83378b0..e45906e 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -672,6 +672,13 @@ def check_sanity_everybuild(status, d):
with open(checkfile, "w") as f:
f.write(tmpdir)
+ # Check if TMPDIR contains invalid characters, and check if it is an
absolute path
+ valid_tmpdir_regexp = "^/[a-zA-Z0-9\-_/.~]+$"
+ import re
+ valid_pattern = re.compile(valid_tmpdir_regexp)
+ if not valid_pattern.match(tmpdir):
+ status.addresult("Error, you have special characters in TMPDIR directory
path or your TMPDIR is not an absolute path. The TMPDIR should match the this regexp:
^/[a-zA-Z0-9\-_/.~]$")
+
def check_sanity(sanity_data):
import subprocess
Check the wording of the warning "The TMPDIR should match the this regexp"
should probably be "The TMPDIR should match this regexp" or maybe use a simpler
version like "The TMPDIR name should must be an absolute path and contain only
letters,
digits and the characters -_"
Also, is "-" actually valid? I seem to recall having problems when my build
tree had the hyphen ("-") in the path.
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
