On Thu, Dec 5, 2013 at 9:25 PM, Saul Wold <[email protected]> wrote:

>
> Andrei:
>
> I see RP already merged this, but I have a couple of comments
>
>
>
> On 12/05/2013 01:01 AM, Andrei Gherzan wrote:
>
>> Signed-off-by: Andrei Gherzan <[email protected]>
>> ---
>>   .../0001-configure-enable-pic-for-AArch64.patch                   | 0
>>   meta/recipes-multimedia/libav/{libav_0.8.8.bb => libav_0.8.9.bb}  | 8
>> +++-----
>>   2 files changed, 3 insertions(+), 5 deletions(-)
>>   rename meta/recipes-multimedia/libav/{libav-0.8.8 =>
>> libav-0.8.9}/0001-configure-enable-pic-for-AArch64.patch (100%)
>>   rename meta/recipes-multimedia/libav/{libav_0.8.8.bb => libav_0.8.9.bb}
>> (69%)
>>
>> diff --git a/meta/recipes-multimedia/libav/libav-0.8.8/0001-
>> configure-enable-pic-for-AArch64.patch b/meta/recipes-multimedia/
>> libav/libav-0.8.9/0001-configure-enable-pic-for-AArch64.patch
>> similarity index 100%
>> rename from meta/recipes-multimedia/libav/libav-0.8.8/0001-configure-
>> enable-pic-for-AArch64.patch
>> rename to meta/recipes-multimedia/libav/libav-0.8.9/0001-configure-
>> enable-pic-for-AArch64.patch
>>
>
> We are generally trying to get rid of versioned patch directory in favor
> of just a general recipe name (libav in this case).
>
>
>  diff --git 
> a/meta/recipes-multimedia/libav/libav_0.8.8.bbb/meta/recipes-multimedia/
>> libav/libav_0.8.9.bb
>> similarity index 69%
>> rename from meta/recipes-multimedia/libav/libav_0.8.8.bb
>> rename to meta/recipes-multimedia/libav/libav_0.8.9.bb
>> index 9cb4cf2..065a6d2 100644
>> --- a/meta/recipes-multimedia/libav/libav_0.8.8.bb
>> +++ b/meta/recipes-multimedia/libav/libav_0.8.9.bb
>> @@ -1,10 +1,10 @@
>>   require libav.inc
>>
>> -SRC_URI = "http://libav.org/releases/libav-0.8.8.tar.xz \
>> +SRC_URI = "http://libav.org/releases/libav-0.8.9.tar.xz \
>>
> why not convert this to ${BP} so it does not need to be edited in the
> future. BP = BPN-PV.
>
> Sau!


Pushing a patch to address these comments. Thanks.

-- 
*ag*
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Reply via email to