On 9 January 2014 08:25, <[email protected]> wrote: > Function tests: > 1)gzip compress file > 2)compressed file integrity check > 3)zcat compress file > 4)gzip decompress file
Wouldn't this be better implemented as a ptest for gzip? The qemu image tests are more concerned with image-wide functionality that can't be unit tested independently, but verifying that gzip works can be. Also, your test simply verifies that the commands execute, not that the contents is what you expect: a gzip that produced corrupted archives wouldn't be detected by this test. Finally, as I learnt yesterday, the skipUnlessPassed decorator isn't used to enforce ordering, so test_gzip_fun1_compress only runs after _create_testfile because it sorts that way alphabetically, not because of your decorators. As creating a file isn't a test, just do that in the test itself. Ross _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
