On Fri, Feb 28, 2014 at 2:26 PM, Chris Larson <[email protected]> wrote:
> I'm guessing that the idea was to add a dependency from diffconfig to > kernel_configme whether or not diffconfig even exists, in order to be > able to support a use case where kernel-yocto is inherited but cml1 is not, > but I'd question the validity of such a use case, personally. I think > either we should consider one of these options: > > 1) Programmatically add the dependency with bb.build.addtask based on > the availability of do_diffconfig > https://gist.github.com/kergoth/9280305 shows what this one looks like, which is the most versatile, but does add additional processing at the end of parse time, though not much. I think this is probably our best bet as it still supports the use cases implied by the way kernel-yocto.bbclass and linux-yocto.inc are structured. > 2) Use addtask to express the dependency in linux-yocto.inc, where > do_kernel_configme gets added as a task. Having do_diffconfig depend on > do_kernel_configme for a recipe that doesn't include linux-yocto.inc would > result in breakage anyway unless they explicitly addtask do_kernel_configme > in that recipe. > https://gist.github.com/kergoth/9280352 shows this version, which would mean that anyone using kernel-yocto.bbclass and cml1.bbclass but not linux-yocto.bbclass wouldn't get the diffconfig -> kernel_configme dependency set -- Christopher Larson clarson at kergoth dot com Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics
_______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
