On Thu, Mar 6, 2014 at 6:02 AM, Matt Fleming <[email protected]> wrote: > On Wed, 05 Mar, at 12:02:27PM, Bruce Ashfield wrote: >> Please cc' me directly on any kernel-yocto changes, I only noticed this >> by chance. > > Noted. > >> On Wed, Mar 5, 2014 at 11:49 AM, Matt Fleming <[email protected]> wrote: >> > >> > Furthermore, the output of 'git branch' is subject to change and trying >> > to parse it could potentially lead to breakage in the future. >> >> I've never had a problem with it in 7 years of the tools and their variants, >> so >> the point is arguable and could be dropped from the commit log. > > I'm referring to this,
Yah, I've seen similar warnings as well, I'm a fan of symbolic-ref after getting burned poking directly into the .git directory structure in the past :) The more usable primitives are much better than they used to be. But I'm in a pragmatic mood lately and will keep an eye out for a real world break .. and then everyone can tell me that they told me so. Cheers, Bruce > > > http://git-blame.blogspot.co.uk/2013/06/checking-current-branch-programatically.html > >> Good catch on the issue, like I said, I've never run into it .. but I >> can definitely see the need for the tweak. > > OK, I'll send an updated version. Thanks for the review. > > -- > Matt Fleming, Intel Open Source Technology Center -- "Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end" _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
