On Tuesday 18 March 2014 15:15:23 Burton, Ross wrote: > On 18 March 2014 07:11, Chong Lu <[email protected]> wrote: > > +PACKAGES += "dbus-ptest" > > This should be conditional on DISTRO_FEATURES containing ptest. > > > +ALLOW_EMPTY_${PN}-ptest = "1" > > +RDEPENDS_dbus-ptest = "dbus-test-ptest" > > Please be consistent with the use of dbus-ptest and ${PN}-ptest. > > > +RPROVIDES_dbus-ptest = "${@base_contains('DISTRO_FEATURES', 'ptest', '', > > 'dbus-test-ptest', d)}" > > This line took me a minute to understand and won't be needed if the > PACKAGES addition is conditional.
Right, agreed on all three. Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
