Please see inline.
On 04/01/2014 02:23 PM, Iorga, Cristian wrote:
Hi all,
I would also say that is an important change, with some possible unforeseen
consequences.
The YP is in the stabilization phase for 1.6 release.
In my opinion, the support for and change to BlueZ (overall) should be
postponed to 1.7.
Also, this not the proper solution, because, in the end, if BlueZ4 will still
be around in 1.7 (which is not my intention, to be honest), this will be worked
out with a Bluetooth stack provider (which can be BZ4 or, preferably, BZ5).
I vote against this patch.
The idea was that people could just have bluetooth in DISTRO_FEATURES
and things would be unchanged, as in use bluez4 like now, and if
somebody else wants bluez5, just add bluez5 to PACKAGECONFIG in some
.bbappend's and not rely on the bluetooth DISTRO_FEATURE until bluez5
supersedes bluez4.
At the moment, one cannot use bluez5 as connman and libpcap explicitly
depend on bluez4.
Regards,
Cristian Iorga
YP
Intel Corporation
-----Original Message-----
From: [email protected]
[mailto:[email protected]] On Behalf Of Richard
Purdie
Sent: Tuesday, April 1, 2014 1:51 PM
To: Sarbu, Florin-Ionut (Wind River)
Cc: [email protected]
Subject: Re: [OE-core] [PATCH] connman.inc: Add PACKAGECONFIG support for bluez5
On Tue, 2014-04-01 at 13:09 +0300, Florin Sarbu wrote:
Currently connman can only RDEPEND on bluez4.
This patch adds support for having bluez5 in PACKAGECONFIG and get
connman RDEPEND on bluez5 if desired.
Signed-off-by: Florin Sarbu <[email protected]>
---
meta/recipes-connectivity/connman/connman.inc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-connectivity/connman/connman.inc
b/meta/recipes-connectivity/connman/connman.inc
index b3147c9..53a6a4f 100644
--- a/meta/recipes-connectivity/connman/connman.inc
+++ b/meta/recipes-connectivity/connman/connman.inc
@@ -32,7 +32,7 @@ EXTRA_OECONF += "\
PACKAGECONFIG ??= "wispr \
${@base_contains('DISTRO_FEATURES', 'wifi','wifi', '', d)}
\
- ${@base_contains('DISTRO_FEATURES',
'bluetooth','bluetooth', '', d)} \
+ ${@base_contains('DISTRO_FEATURES',
+ 'bluetooth','bluez4', '', d)} \
${@base_contains('DISTRO_FEATURES', '3g','3g', '',
d)} \ "
@@ -42,6 +42,7 @@ PACKAGECONFIG ??= "wispr \
PACKAGECONFIG[wifi] = "--enable-wifi, --disable-wifi, wpa-supplicant"
PACKAGECONFIG[bluetooth] = "--enable-bluetooth, --disable-bluetooth, bluez4"
You renamed the option above but didn't here and hence broke bluez4.
This is not the quality of patch expected at -rc time for a release :(.
Sorry, I overlooked the change in that one and the others remaining
after that.
Cheers,
Richard
+PACKAGECONFIG[bluez5] = "--enable-bluetooth, --disable-bluetooth, bluez5"
Also, to not get it disable bluetooth when using bluez4, the above line
should look something like:
+PACKAGECONFIG[bluez5] = "--enable-bluetooth, , bluez5"
Want me to send another patch or we just drop it and people just do what
they need in their own .bbappend's in order to have bluez5 in?
Thank you,
Florin
PACKAGECONFIG[3g] = "--enable-ofono, --disable-ofono, ofono"
PACKAGECONFIG[tist] = "--enable-tist,--disable-tist,"
PACKAGECONFIG[openvpn] = "--enable-openvpn
--with-openvpn=${sbindir}/openvpn,--disable-openvpn,,openvpn"
@@ -114,6 +115,7 @@ RPROVIDES_${PN} = "\ RDEPENDS_${PN} = "\
dbus \
${@base_contains('PACKAGECONFIG', 'bluetooth', 'bluez4', '', d)} \
+ ${@base_contains('PACKAGECONFIG', 'bluez5', 'bluez5', '', d)} \
${@base_contains('PACKAGECONFIG', 'wifi','wpa-supplicant', '', d)} \
${@base_contains('PACKAGECONFIG', '3g','ofono', '', d)} \
xuser-account \
--
1.9.1
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
