On 04/01/2014 08:34 PM, Paul Barker wrote:
On 1 April 2014 13:31, Phil Blundell <[email protected]> wrote:
On Tue, 2014-04-01 at 12:41 +0100, Paul Barker wrote:
The more I look at it the more I don't like this patch. It's probably
a very rarely used code path but it could blow up if it's called. C
provides no guarantees that calling a 3-argument function with only 2
arguments will work. Depending on calling convention it could easily
result in stack corruption on some platforms.
I'd suggest we try reverting the relevant bits of the upstream change
from qsort to
qsort_r:
http://git.kernel.org/cgit/utils/util-linux/util-linux.git/commit/?id=c69bbca9c1f6645097bd20fe3a21f5a99a2a0698
I think it should just be the first 3 patch hunks in that commit.
It seems vanishingly unlikely that anybody is seriously going to try to
use fdisk from util-linux-native to manipulate Sun partition tables and,
that being the case, it's presumably going to be quite hard to test any
such change. Maybe we should just turn off support for these fringe
partition table types altogether.
That may be a much, much easier fix.
Thank you very much, I will send a patch later:-)
// Robert
I've reported this to the upstream mailing list anyway as there really
should be an autoconf check for qsort_r.
Thanks,
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
