On 04/09/2014 05:28 PM, Richard Purdie wrote:
On Wed, 2014-04-09 at 15:49 +0800, Chong Lu wrote:
On 04/08/2014 06:08 PM, Richard Purdie wrote:
On Tue, 2014-04-08 at 09:40 +0800, Chong Lu wrote:
On 04/04/2014 06:41 PM, Richard Purdie wrote:
On Fri, 2014-04-04 at 16:33 +0800, Chong Lu wrote:
Delete "<<<" syntax of bash in Makefile, else we would get following error:
Syntax error: redirection unexpected
[YOCTO #6112]
Signed-off-by: Chong Lu <[email protected]>
---
meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb | 3 ++-
.../kernelshark-fix-syntax-error-of-shell.patch | 30
++++++++++++++++++++++
.../trace-cmd-fix-syntax-error-of-shell.patch | 30
++++++++++++++++++++++
meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb | 1 +
4 files changed, 63 insertions(+), 1 deletion(-)
create mode 100644
meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
create mode 100644
meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch
diff --git a/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
b/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
index 9268a50..d61097d 100644
--- a/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
+++ b/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb
@@ -15,7 +15,8 @@ inherit pkgconfig pythonnative
SRC_URI =
"git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git \
file://addldflags.patch \
file://make-docs-optional.patch \
- file://blktrace-api-compatibility.patch"
+ file://blktrace-api-compatibility.patch \
+ file://kernelshark-fix-syntax-error-of-shell.patch"
S = "${WORKDIR}/git"
EXTRA_OEMAKE = "'CC=${CC}' 'AR=${AR}' 'prefix=${prefix}' gui"
diff --git
a/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
b/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
new file mode 100644
index 0000000..994a9fa
--- /dev/null
+++
b/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch
@@ -0,0 +1,30 @@
+kernelshark: fix syntax error of shell
+
+Delete "<<<" syntax of bash in Makefile, else we would get following error:
+
+ Syntax error: redirection unexpected
+
+Upstream-Status: Inappropriate [embedded specific]
How is this embedded specific?
Cheers,
Richard
This issue only produced in yocto.
It is not problem for kernelshark and trace-cmd itself.
So I think this is embedded specific.
I'm afraid I don't accept this explanation. Is Yocto's make different
somehow which causes this error?
I don't understand why yocto would see this error yet other systems
(which use the same make as far as I know) would not.
Cheers,
Richard
Hi Richard,
I built kernelshark and trace-cmd in Ubuntu 12.04.
The dash is default shell in this distrobution.
So, this issue would produce only on host that the default shell is not
bash.
Right, so the Upstream-Status is not "embedded specific", its a general
problems for shells which are not bash?
Cheers,
Richard
Ok, thanks. I got it. I will resend V2.
Best Regards
Chong
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
