2014-05-08 00:21 skrev Richard Purdie:

On Wed, 2014-05-07 at 23:19 +0200, Petter Mabäcker wrote:

Fixes [YOCTO #4497] We extend the search path in a number of recipes by
setting FILESPATH, which is not really desirable since the manner in
which we have done it can make the recipe harder to bbappend (and we
explicitly advise modifying FILESPATH this in the manual). These should be changed to use FILESEXTRAPATHS to extend the path instead or use a
default FILESPATH (e.g. BP, BPN or files).

Whilst FILESPATH is discouraged, so is putting files into "files"
directories so those changes are not an improvement.

Cheers,

Richard

I agree, 'files' is not a good choice and of course BP and BPN are preferred if possible. My intention in this case however was that 'files' was an "less bad" option in the situations where all bb-files within a recipe used a 'common' dir to store patches. In these situations I thought it was more clear to use a name that better displayed the "common use" and since 'files' is quite a common name + that it removes the need of extending the filespath, I used it in theses situations. But I guess you could see 'BPN' as a common dir as well since it's the same name as the recipe (even if they are used by other bb-files with different PN within the same recipe). So I will change those commits that are using 'files' and use either BPN as a "shared patchdir" or try to split them into different PN/P dirs if possible.

BR,
Petter
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Reply via email to