On Mon, Apr 28, 2014 at 2:36 PM, Dan McGregor <[email protected]> wrote: > On 23 April 2014 20:37, Khem Raj <[email protected]> wrote: >> >> On Wed, Apr 23, 2014 at 9:43 AM, Dan McGregor <[email protected]> >> wrote: >> > On 23 April 2014 10:34, Saul Wold <[email protected]> wrote: >> >> >> >> On 04/23/2014 08:01 AM, Dan McGregor wrote: >> >>> >> >>> From: Dan McGregor <[email protected]> >> >>> >> >>> Explicitly mark the dummy function as externally visible >> >>> so that ld can find the symbol at link time. This is needed >> >>> when the DISTRO_FEATURE ld-is-gold is not enabled; systemd >> >>> uses -flto anyway. >> >>> >> >>> Signed-off-by: Dan McGregor <[email protected]> >> >>> --- >> >>> meta/recipes-core/systemd/systemd/systemd-lto-fix.patch | 14 >> >>> ++++++++++++++ >> >>> meta/recipes-core/systemd/systemd_211.bb | 1 + >> >>> 2 files changed, 15 insertions(+) >> >>> create mode 100644 >> >>> meta/recipes-core/systemd/systemd/systemd-lto-fix.patch >> >>> >> >>> diff --git a/meta/recipes-core/systemd/systemd/systemd-lto-fix.patch >> >>> b/meta/recipes-core/systemd/systemd/systemd-lto-fix.patch >> >>> new file mode 100644 >> >>> index 0000000..90875e4 >> >>> --- /dev/null >> >>> +++ b/meta/recipes-core/systemd/systemd/systemd-lto-fix.patch >> >> >> >> >> >> The patch also needs an appropriate Upstream-Status and Signed-off-by >> >> tags >> >> here. >> >> >> >> Thanks >> >> Sau! >> >> >> > >> > As I said to Ross off-list (accidentally), this patch was for Linaro GCC >> > as >> > of 2014-03-20. I'm going to check that it's still vald, and if so I'll >> > send >> > it upstream too. >> >> FWIW, I have updated the systemd recipe to 212+ its here >> >> http://git.openembedded.org/openembedded-core-contrib/commit/?h=kraj/musl&id=f4283b924c13ea4d98b4251e11dd6a3388f195d5 >> >> can you check if this patch is still needed there ? I use gold/arm and >> did not run into this issue. >> > > I just reran it, and it does indeed fail with meta-linaro-toolchain, > gcc_linaro-4.8, and binutils_linaro-2.24. It builds fine with my patch.
I took another look at this patch. I think you should get feedback from systemd community on it. It seems to me that its happening in conjunction with LTO and there could be a back port in linaro gcc which is triggering it. In that case sooner or later it will show up with upstream gcc as well. -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
