Just nitpicking a little... It should ideally have had a [PATCH v2] header, to make it easier to see that it's an updated patch.
If Saul or someone else picks this up, there should be no need to resubmit. But anyway, for the next time. * Corneliu Stoicescu <[email protected]> [140527 09:46]: > Using '&&' as condition operator in '[ ! -e /mnt/testrootfs/boot/uImage ] && > cp ~/test-kernel /mnt/testrootfs/boot/uImage' would result in exit code 1 if > the first condition is not met. > Changing the code to handle the conditioning more cleanly and correctly > return exit status 0 if [ ! -e /mnt/testrootfs/boot/uImage ] returns exit > code 1. Preferably, the commit message should be line wrapped at ~78 chars. > Without this if the file existance check would fail then the image deploy > task would stop. > Signed-off-by: Corneliu Stoicescu <[email protected]> > --- A short changelog between version should go here. (In this case just stating that the commit message was improved). Cheers, Anders -- Anders Darander ChargeStorm AB / eStorm AB -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
