On Fri, Aug 15, 2014 at 11:00:46AM +0800, ChenQi wrote: > On 08/14/2014 05:39 PM, Richard Purdie wrote: > > On Thu, 2014-08-14 at 10:54 +0200, Martin Jansa wrote: > >> On Thu, Aug 14, 2014 at 04:46:01PM +0800, Chen Qi wrote: > >>> Add libdw to RDEPENDS of systemd to avoid build-deps QA warning. > >>> > >>> Signed-off-by: Chen Qi <qi.c...@windriver.com> > >>> --- > >>> meta/recipes-core/systemd/systemd_215.bb | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/meta/recipes-core/systemd/systemd_215.bb > >>> b/meta/recipes-core/systemd/systemd_215.bb > >>> index 770787b..a52a042 100644 > >>> --- a/meta/recipes-core/systemd/systemd_215.bb > >>> +++ b/meta/recipes-core/systemd/systemd_215.bb > >>> @@ -244,7 +244,7 @@ FILES_${PN} = " ${base_bindir}/* \ > >>> FILES_${PN}-dbg += "${rootlibdir}/.debug ${systemd_unitdir}/.debug > >>> ${systemd_unitdir}/*/.debug ${base_libdir}/security/.debug/" > >>> FILES_${PN}-dev += "${base_libdir}/security/*.la > >>> ${datadir}/dbus-1/interfaces/ ${sysconfdir}/rpm/macros.systemd" > >>> > >>> -RDEPENDS_${PN} += "kmod dbus util-linux-mount udev (= ${EXTENDPKGV})" > >>> +RDEPENDS_${PN} += "libdw kmod dbus util-linux-mount udev (= > >>> ${EXTENDPKGV})" > >> Shouldn't it be build-time dependency? > >> > >> If it's detected from sysroot in do_configure then it has to be in > >> DEPENDS to get deterministic results. > > Right. Secondly, what benefit does this library bring us? > > > > Cheers, > > > > Richard > > > > > > > > Richard & Martin, > > Thanks for reminding me about this. > I shouldn't have rushed into fixing the QA warning without looking into > the configure.ac file. > > It should really be a PACKAGECONFIG for 'elfutils'. > PACKAGECONFIG[elfutils] = "--enable-elfutils,--disable-elfutils,libelf > libdw,libelf libdw"
I don't think there is libdw and libelf recipe, they are just packages created by elfutils recipe, so I think it should be: PACKAGECONFIG[elfutils] = "--enable-elfutils,--disable-elfutils,elfutils" the runtime dependency is added automatically by shlibs code (as the QA warning confirmed). > I will send out V2 of this patchset. > > Best Regards, > Chen Qi -- Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com
signature.asc
Description: Digital signature
-- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core