On Tue, Sep 30, 2014 at 5:00 PM, Bruce Ashfield <bruce.ashfi...@windriver.com> wrote: > On 2014-09-30, 4:57 PM, nitin.a.kam...@intel.com wrote: >> >> From: Nitin A Kamble <nitin.a.kam...@intel.com> >> >> To build external modules, the link /lib/modules/<kernel-version>/build >> must exist, and point to the proper kernel source area. >> >> The kernel-dev package already provides the needed source files. Now >> putting a link in place to unblock the external module building. > > > This description is not entirely accurate, at least from my point of > view. > > You can build external modules on the target without this link .. it is > that many scripts and utilities look in this location for the kernel > source. > > We are fixing that case, not the general case of building an external > module.
I forgot to say, that outside of my nit picking on the commit message, I don't see any significant issues with the patch. Cheers, Bruce > > Cheers, > > Bruce > > >> >> Fixes Bug: >> [YOCTO #2968] >> >> Signed-off-by: Nitin A Kamble <nitin.a.kam...@intel.com> >> --- >> meta/classes/kernel.bbclass | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass >> index 78b33ce..5ac4ff4 100644 >> --- a/meta/classes/kernel.bbclass >> +++ b/meta/classes/kernel.bbclass >> @@ -213,6 +213,7 @@ kernel_do_install() { >> # >> kerneldir=${D}${KERNEL_SRC_PATH} >> install -d $kerneldir >> + ln -sf ${KERNEL_SRC_PATH} >> "${D}/lib/modules/${KERNEL_VERSION}/build" >> >> # >> # Store the kernel version in sysroots for module-base.bbclass >> @@ -346,7 +347,7 @@ PACKAGES = "kernel kernel-base kernel-vmlinux >> kernel-image kernel-dev kernel-mod >> FILES_${PN} = "" >> FILES_kernel-base = "/lib/modules/${KERNEL_VERSION}/modules.order >> /lib/modules/${KERNEL_VERSION}/modules.builtin" >> FILES_kernel-image = "/boot/${KERNEL_IMAGETYPE}*" >> -FILES_kernel-dev = "/boot/System.map* /boot/Module.symvers* /boot/config* >> ${KERNEL_SRC_PATH}" >> +FILES_kernel-dev = "/boot/System.map* /boot/Module.symvers* /boot/config* >> ${KERNEL_SRC_PATH} /lib/modules/${KERNEL_VERSION}/build" >> FILES_kernel-vmlinux = "/boot/vmlinux*" >> FILES_kernel-modules = "" >> RDEPENDS_kernel = "kernel-base" >> > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core -- "Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end" -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core