On 12 November 2014 17:18, Alejandro Hernandez <
[email protected]> wrote:

> Signed-off-by: Alejandro Hernandez <[email protected]>
> ---
>  meta/recipes-extended/cronie/cronie_1.4.11.bb | 85
> ---------------------------
>  meta/recipes-extended/cronie/cronie_1.4.12.bb | 84
> ++++++++++++++++++++++++++
>

Please pass -M to git-send-email if you're sending patches without using
create-pull-request so that the rename is spotted and the diff is much
easier to read. I applied and re-generated the diff:

--- a/meta/recipes-extended/cronie/cronie_1.4.11.bb
> +++ b/meta/recipes-extended/cronie/cronie_1.4.12.bb
> @@ -8,7 +8,7 @@ BUGTRACKER = "[email protected]"
>  # Internet Systems Consortium License
>  LICENSE = "ISC & BSD"
> -LIC_FILES_CHKSUM = "file://COPYING;md5=963ea0772a2adbdcd607a9b2ec320c11 \
> +LIC_FILES_CHKSUM = "file://COPYING;md5=dd2a592170760e1386c769e1043b3722 \
>
>  file://src/cron.c;endline=20;md5=b425c334265026177128353a142633b4 \


Always say why the license checksum was change in the commit message.
Often it's just copyright dates changing or reformatting, but we need to
know that it's not that the license terms were changed.


>  SRC_URI = "
> https://fedorahosted.org/releases/c/r/cronie/cronie-${PV}.tar.gz \
> -           file://fix-out-of-tree-build.patch \
>

If a patch is removed explain why (upstream merged it in this case, I
hope), and remember to remove the file in the commit.

Ross
-- 
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Reply via email to