Hi Ross, Can you point me to a tutorial in this kind of test suites? /Cristian
From: Burton, Ross [mailto:[email protected]] Sent: Thursday, February 26, 2015 10:08 PM To: Iorga, Cristian Cc: OE-core Subject: Re: [OE-core] [PATCH 1/1] meta/lib/oe/utils.py: properly implement both_contain() On 25 February 2015 at 15:15, Cristian Iorga <[email protected]<mailto:[email protected]>> wrote: oe.utils.both_contain() just does a find() on the value rather than splitting the value and then looking in the list of split items. The result is that if you add a feature to MACHINE_FEATURES that itself has a substring that matches one of the values looked for when building COMBINED_FEATURES, you end up with an incomprehensible error (here with "ext2i" in MACHINE_FEATURES): This looks right but you know what it needs: a test suite. Add a small test case that demonstrates it breaking before the fix and then working after the fix. We've been adding test cases to bitbake as bugs are found and it's really helping demonstrate that changes work. Ross
-- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
