Hi Ross, I didn’t know such a function was existing. You can use it of course, it’s much better. I found the (obscure) regexp in libcgroup recipe, it could be updated too.
Is it worth it I send a v2 patch ? Matthieu De : Burton, Ross [mailto:[email protected]] Envoyé : mercredi 20 mai 2015 16:42 À : Matthieu CRAPET Cc : [email protected] Objet : Re: [OE-core] [PATCH] zlib: minor symbolic link issue On 20 May 2015 at 10:47, Matthieu CRAPET <[email protected]<mailto:[email protected]>> wrote: Just tell me if something is wrong, I can provide a v2 patch. No, it just slipped through the cracks. That regex looked a bit obscure, and there's a Python function we provide that uses the Python standard library to do the same thing, so I ended up with this locally: # Move zlib shared libraries for target builds to $base_libdir so the library # can be used in early boot before $prefix is mounted. do_install_append_class-target() { if [ ${base_libdir} != ${libdir} ] then mkdir -p ${D}/${base_libdir} mv ${D}/${libdir}/libz.so.* ${D}/${base_libdir} libname=`readlink ${D}/${libdir}/libz.so` ln -sf ${@oe.path.relative("${libdir}<mailto:$%[email protected](%22$%7blibdir%7d>", "${base_libdir}")}/$libname ${D}${libdir}/libz.so fi } Do you have any objections to this form instead? I'm also thinking we should rationalise the duplicated logic into a single implementation in meta/classes/utils.bbclass... Ross
-- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
