On Thursday 11 June 2015 14:34:15 Markus Lehtonen wrote: > Signed-off-by: Markus Lehtonen <[email protected]> > --- > scripts/devtool | 1 - > scripts/lib/devtool/standard.py | 3 --- > 2 files changed, 4 deletions(-) > > diff --git a/scripts/devtool b/scripts/devtool > index 0100eb8..307846a 100755 > --- a/scripts/devtool > +++ b/scripts/devtool > @@ -157,7 +157,6 @@ def _enable_workspace_layer(workspacedir, config, > basepath): bblayers_conf = os.path.join(basepath, 'conf', 'bblayers.conf') > if not os.path.exists(bblayers_conf): > logger.error('Unable to find bblayers.conf') > - return -1
I appreciate the actually returned value might not be used, but simply dropping the return entirely allows the function to continue after the error, which is wrong. Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
