Hi Paul,

On 07/01/2015 07:54 AM, Paul Eggleton wrote:
Hi Leonardo,

On Tuesday 30 June 2015 11:19:40 [email protected]
wrote:
From: Leonardo Sandoval <[email protected]>

This is just a safe check to make sure the output folder is present, before
creating the files-in-$pkg.txt file.

Signed-off-by: Leonardo Sandoval
<[email protected]> ---
  meta/classes/buildhistory.bbclass | 8 +++++++-
  1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/meta/classes/buildhistory.bbclass
b/meta/classes/buildhistory.bbclass index 8fc8a3a..cad5116 100644
--- a/meta/classes/buildhistory.bbclass
+++ b/meta/classes/buildhistory.bbclass
@@ -444,7 +444,13 @@ buildhistory_list_pkg_files() {
          # Create individual files-in-package for each recipe's package
          for pkgdir in $(find ${PKGDEST}/* -maxdepth 0 -type d); do
                  pkgname=$(basename ${pkgdir})
-
outfile="${BUILDHISTORY_DIR_PACKAGE}/${pkgname}/${file_prefix}${pkgname}.tx
t" +                outfolder="${BUILDHISTORY_DIR_PACKAGE}/${pkgname}" +
            outfile="${outfolder}/${file_prefix}${pkgname}.txt" +
     # Make sure the output folder, exist so we can create the
files-in-$pkgname.txt file +                if [ ! -d ${outfolder} ] ; then
+                        bbdebug 2 "Folder ${outfolder} does not exist, file
${outfile} not created" +                        continue

This isn't the way we normally handle this sort of situation - we should be
simply creating the directory unconditionally before writing the file.

In any case, how is it that the directory doesn't exist at this point?

files-in-$pkg.txt files are created and placed on top of the corresponding buildhistory/packages folders. By the time this task is done, the latter folders are *already* created, so that is why in the first patch version, I did not include the check. BTW, I could not reproduce the issue that Andre had (failed on cairo) so I will ask him more detail on his setup.
Cheers,
Paul

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Reply via email to