On 25/08/15 17:58, Richard Purdie wrote:
I'm torn over this, I can see someone wanting this to vary in each build. What pushed me to believe its incorrect in its current form is that it changes for every MACHINE build, making a complete mess if you try and generate package feeds using it.
It's also worth pointing out that the BUILD_ID isn't included in the generated os-release file unless you add BUILD_ID to OS_RELEASE_FIELDS.
I'm personally not certain whether DATETIME makes sense as BUILD_ID a multi-MACHINE distro anyway.
Cheers, Joshua
The alternative would be to give up on allarch in this case and make it MACHINE specific which at least would then be more consistent when the package makes it to a package feed. If someone wants to do that, the can propose another patch but this change at least make package feed usage 'sane' again and avoids the perpetual rebuilds. Incidentally, its worth noting that changes in source metadata revision used for the build and included in this recipe would still trigger rebuilds which is likely the common use case people actually care about. Signed-off-by: Richard Purdie <[email protected]> diff --git a/meta/recipes-core/os-release/os-release.bb b/meta/recipes-core/os-release/os-release.bb index 87fea6f..10a4570 100644 --- a/meta/recipes-core/os-release/os-release.bb +++ b/meta/recipes-core/os-release/os-release.bb @@ -21,6 +21,7 @@ VERSION = "${DISTRO_VERSION}${@' (%s)' % DISTRO_CODENAME if 'DISTRO_CODENAME' in VERSION_ID = "${DISTRO_VERSION}" PRETTY_NAME = "${DISTRO_NAME} ${VERSION}" BUILD_ID ?= "${DATETIME}" +BUILD_ID[vardepsexclude] = "DATETIME" python do_compile () { with open(d.expand('${B}/os-release'), 'w') as f:
-- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
